search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Fix file size reader #3095

Closed Sheikah45 closed 6 months ago

Sheikah45 commented 6 months ago

Closes #3045

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4fdd77d) 59.07% compared to head (60d0658) 59.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3095 +/- ## ============================================= + Coverage 59.07% 59.09% +0.01% - Complexity 4409 4412 +3 ============================================= Files 562 562 Lines 20159 20159 Branches 1014 1014 ============================================= + Hits 11909 11913 +4 + Misses 7709 7707 -2 + Partials 541 539 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...java/com/faforever/client/util/FileSizeReader.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3095?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91dGlsL0ZpbGVTaXplUmVhZGVyLmphdmE=) | `8.33% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3095/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3095?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3095?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [4fdd77d...60d0658](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3095?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).