search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Remove inappropriate usage of @Async #3096

Closed Sheikah45 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c63001d) 59.05% compared to head (fc73ac4) 59.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3096 +/- ## ============================================= + Coverage 59.05% 59.08% +0.02% - Complexity 4410 4411 +1 ============================================= Files 562 562 Lines 20159 20158 -1 Branches 1014 1014 ============================================= + Hits 11905 11910 +5 + Misses 7713 7708 -5 + Partials 541 540 -1 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...forever/client/featuredmod/FeaturedModService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mZWF0dXJlZG1vZC9GZWF0dXJlZE1vZFNlcnZpY2UuamF2YQ==) | `64.51% <ø> (ø)` | | | [...va/com/faforever/client/game/GamePrefsService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVQcmVmc1NlcnZpY2UuamF2YQ==) | `42.85% <ø> (ø)` | | | [...main/java/com/faforever/client/map/MapService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `71.59% <ø> (+0.88%)` | :arrow_up: | | [...main/java/com/faforever/client/mod/ModService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tb2QvTW9kU2VydmljZS5qYXZh) | `65.67% <ø> (+0.42%)` | :arrow_up: | | [...java/com/faforever/client/util/FileSizeReader.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91dGlsL0ZpbGVTaXplUmVhZGVyLmphdmE=) | `8.33% <ø> (ø)` | | | [...om/faforever/client/update/CheckForUpdateTask.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91cGRhdGUvQ2hlY2tGb3JVcGRhdGVUYXNrLmphdmE=) | `4.34% <0.00%> (+0.18%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [c63001d...fc73ac4](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3096?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).