search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Use 127.0.0.1 for arbitrary port in callback url #3102

Closed Sheikah45 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f286c06) 58.78% compared to head (201f17d) 58.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3102 +/- ## ============================================= - Coverage 58.78% 58.73% -0.05% + Complexity 4400 4395 -5 ============================================= Files 563 563 Lines 20217 20189 -28 Branches 1018 1011 -7 ============================================= - Hits 11884 11859 -25 - Misses 7801 7804 +3 + Partials 532 526 -6 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../com/faforever/client/config/ClientProperties.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2xpZW50UHJvcGVydGllcy5qYXZh) | `52.03% <ø> (-0.39%)` | :arrow_down: | | [...va/com/faforever/client/login/LoginController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9Mb2dpbkNvbnRyb2xsZXIuamF2YQ==) | `91.41% <100.00%> (+1.90%)` | :arrow_up: | | [...om/faforever/client/login/OAuthValuesReceiver.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9PQXV0aFZhbHVlc1JlY2VpdmVyLmphdmE=) | `95.08% <90.90%> (+0.79%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [f286c06...201f17d](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3102?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).