search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Use server state to mark players as offline #3104

Closed Sheikah45 closed 6 months ago

Sheikah45 commented 6 months ago

Requires https://github.com/FAForever/server/pull/832

codecov[bot] commented 6 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (d8c11ad) 58.95% compared to head (05fbae0) 58.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3104 +/- ## ============================================= + Coverage 58.95% 58.97% +0.02% - Complexity 4381 4395 +14 ============================================= Files 567 568 +1 Lines 20006 20038 +32 Branches 983 983 ============================================= + Hits 11795 11818 +23 - Misses 7700 7707 +7 - Partials 511 513 +2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../faforever/client/chat/ChatUserItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRVc2VySXRlbUNvbnRyb2xsZXIuamF2YQ==) | `63.97% <100.00%> (ø)` | | | [...orever/client/filter/ChatUserFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvQ2hhdFVzZXJGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `84.09% <100.00%> (+2.03%)` | :arrow_up: | | [...rever/client/fx/contextmenu/WatchGameMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9XYXRjaEdhbWVNZW51SXRlbS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...va/com/faforever/client/game/PlayerGameStatus.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL1BsYXllckdhbWVTdGF0dXMuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...ever/client/leaderboard/LeaderboardController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sZWFkZXJib2FyZC9MZWFkZXJib2FyZENvbnRyb2xsZXIuamF2YQ==) | `91.04% <100.00%> (ø)` | | | [...main/java/com/faforever/client/map/MapService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `71.30% <100.00%> (-0.30%)` | :arrow_down: | | [...java/com/faforever/client/player/ServerStatus.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wbGF5ZXIvU2VydmVyU3RhdHVzLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...ent/teammatchmaking/PartyMemberItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvUGFydHlNZW1iZXJJdGVtQ29udHJvbGxlci5qYXZh) | `80.23% <100.00%> (ø)` | | | [...in/java/com/faforever/client/domain/PartyBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vUGFydHlCZWFuLmphdmE=) | `83.87% <50.00%> (ø)` | | | [...er/client/fx/contextmenu/InvitePlayerMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9JbnZpdGVQbGF5ZXJNZW51SXRlbS5qYXZh) | `83.33% <0.00%> (ø)` | | | ... and [6 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [d8c11ad...05fbae0](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3104?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).