FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Use non webview based chat #3106

Closed Sheikah45 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (5067d5e) 59.08% compared to head (7f43e05) 58.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3106 +/- ## ============================================= - Coverage 59.08% 58.99% -0.10% + Complexity 4416 4385 -31 ============================================= Files 565 567 +2 Lines 20122 20006 -116 Branches 990 983 -7 ============================================= - Hits 11889 11802 -87 + Misses 7716 7694 -22 + Partials 517 510 -7 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...forever/client/chat/AbstractChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0Fic3RyYWN0Q2hhdFRhYkNvbnRyb2xsZXIuamF2YQ==) | `46.51% <ø> (ø)` | | | [...in/java/com/faforever/client/chat/ChatChannel.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDaGFubmVsLmphdmE=) | `96.92% <100.00%> (+0.09%)` | :arrow_up: | | [.../com/faforever/client/chat/emoticons/Emoticon.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbi5qYXZh) | `100.00% <100.00%> (+25.00%)` | :arrow_up: | | [...ever/client/chat/emoticons/EmoticonController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbkNvbnRyb2xsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...aforever/client/chat/emoticons/EmoticonsGroup.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbnNHcm91cC5qYXZh) | `100.00% <100.00%> (+25.00%)` | :arrow_up: | | [...lient/chat/emoticons/EmoticonsGroupController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbnNHcm91cENvbnRyb2xsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...r/client/filter/FilterMultiCheckboxController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvRmlsdGVyTXVsdGlDaGVja2JveENvbnRyb2xsZXIuamF2YQ==) | `87.03% <100.00%> (ø)` | | | [...ver/client/filter/MutableListFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvTXV0YWJsZUxpc3RGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `92.59% <100.00%> (ø)` | | | [...om/faforever/client/login/OAuthValuesReceiver.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sb2dpbi9PQXV0aFZhbHVlc1JlY2VpdmVyLmphdmE=) | `84.61% <100.00%> (+0.24%)` | :arrow_up: | | [...lient/map/management/MapsManagementController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvbWFuYWdlbWVudC9NYXBzTWFuYWdlbWVudENvbnRyb2xsZXIuamF2YQ==) | `75.86% <100.00%> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [5067d5e...7f43e05](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3106?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
micheljung commented 5 months ago

@Sheikah45 why was this done? I feel like the chat experience got way worse because of this.

Sheikah45 commented 5 months ago

This was done to allow for replies and reactions in the chat.

And to make the event handling and tooltips more uniform.

Some issues appeared for some users with scrolling where permanent fixes are still being investigated.

Additionally there were memory issues with the webview and how the chat state was handled so this was also used to clean all that up as well.