search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Don't bind users to prompt text to prevent UI lockup #3108

Closed Sheikah45 closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c46d11a) 58.96% compared to head (6418864) 58.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3108 +/- ## ============================================= - Coverage 58.96% 58.96% -0.01% + Complexity 4412 4409 -3 ============================================= Files 565 565 Lines 20124 20123 -1 Branches 995 995 ============================================= - Hits 11867 11866 -1 + Misses 7741 7740 -1 - Partials 516 517 +1 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../faforever/client/chat/ChatUserListController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRVc2VyTGlzdENvbnRyb2xsZXIuamF2YQ==) | `81.53% <100.00%> (-0.42%)` | :arrow_down: | | [...a/com/faforever/client/chat/KittehChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `72.29% <50.00%> (-0.12%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [c46d11a...6418864](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3108?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).