search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Add reaction and reply capability to chat messages #3111

Closed Sheikah45 closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: 162 lines in your changes are missing coverage. Please review.

Comparison is base (e9285eb) 59.00% compared to head (ac4880c) 59.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3111 +/- ## ============================================= + Coverage 59.00% 59.21% +0.21% - Complexity 4401 4468 +67 ============================================= Files 568 574 +6 Lines 20067 20405 +338 Branches 982 1007 +25 ============================================= + Hits 11840 12083 +243 - Misses 7715 7788 +73 - Partials 512 534 +22 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/chat/ChannelTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYW5uZWxUYWJDb250cm9sbGVyLmphdmE=) | `90.12% <100.00%> (ø)` | | | [...in/java/com/faforever/client/chat/ChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRTZXJ2aWNlLmphdmE=) | `0.00% <ø> (ø)` | | | [.../faforever/client/chat/ChatUserItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRVc2VySXRlbUNvbnRyb2xsZXIuamF2YQ==) | `63.97% <100.00%> (ø)` | | | [.../com/faforever/client/chat/emoticons/Emoticon.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbi5qYXZh) | `100.00% <100.00%> (ø)` | | | [...aforever/client/chat/emoticons/EmoticonsGroup.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9FbW90aWNvbnNHcm91cC5qYXZh) | `100.00% <100.00%> (ø)` | | | [.../com/faforever/client/chat/emoticons/Reaction.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2Vtb3RpY29ucy9SZWFjdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | | | [.../java/com/faforever/client/fx/BrowserCallback.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9Ccm93c2VyQ2FsbGJhY2suamF2YQ==) | `66.66% <ø> (+52.38%)` | :arrow_up: | | [.../main/java/com/faforever/client/fx/Controller.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9Db250cm9sbGVyLmphdmE=) | `93.33% <100.00%> (ø)` | | | [...va/com/faforever/client/fx/MenuItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9NZW51SXRlbUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...n/java/com/faforever/client/fx/NodeController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9Ob2RlQ29udHJvbGxlci5qYXZh) | `77.77% <100.00%> (ø)` | | | ... and [25 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [e9285eb...ac4880c](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3111?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).