search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

Add websocket connection for kitteh #3116

Closed Sheikah45 closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (7e4bd5f) 59.15% compared to head (aad3640) 58.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3116 +/- ## ============================================= - Coverage 59.15% 58.93% -0.22% + Complexity 4479 4478 -1 ============================================= Files 574 575 +1 Lines 20463 20546 +83 Branches 1012 1018 +6 ============================================= + Hits 12104 12108 +4 - Misses 7824 7904 +80 + Partials 535 534 -1 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...t/chat/kitteh/event/ChannelRedactMessageEvent.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2tpdHRlaC9ldmVudC9DaGFubmVsUmVkYWN0TWVzc2FnZUV2ZW50LmphdmE=) | `83.33% <ø> (ø)` | | | [...itteh/event/ChannelTargetedRedactMessageEvent.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2tpdHRlaC9ldmVudC9DaGFubmVsVGFyZ2V0ZWRSZWRhY3RNZXNzYWdlRXZlbnQuamF2YQ==) | `0.00% <ø> (ø)` | | | [...t/chat/kitteh/event/PrivateRedactMessageEvent.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2tpdHRlaC9ldmVudC9Qcml2YXRlUmVkYWN0TWVzc2FnZUV2ZW50LmphdmE=) | `83.33% <ø> (ø)` | | | [...er/client/chat/kitteh/listener/RedactListener.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2tpdHRlaC9saXN0ZW5lci9SZWRhY3RMaXN0ZW5lci5qYXZh) | `0.00% <ø> (ø)` | | | [...r/client/chat/kitteh/listener/WhoAwayListener.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2tpdHRlaC9saXN0ZW5lci9XaG9Bd2F5TGlzdGVuZXIuamF2YQ==) | `0.00% <ø> (ø)` | | | [...m/faforever/client/update/ClientConfiguration.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91cGRhdGUvQ2xpZW50Q29uZmlndXJhdGlvbi5qYXZh) | `43.75% <100.00%> (ø)` | | | [...forever/client/chat/ChatMessageViewController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRNZXNzYWdlVmlld0NvbnRyb2xsZXIuamF2YQ==) | `62.87% <83.33%> (+2.05%)` | :arrow_up: | | [...a/com/faforever/client/chat/KittehChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `72.87% <50.00%> (ø)` | | | [.../com/faforever/client/config/ClientProperties.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb25maWcvQ2xpZW50UHJvcGVydGllcy5qYXZh) | `52.03% <75.00%> (ø)` | | | [...t/chat/kitteh/network/WebsocketNetworkHandler.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L2tpdHRlaC9uZXR3b3JrL1dlYnNvY2tldE5ldHdvcmtIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [7e4bd5f...aad3640](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3116?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).