search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Replay card controller tests #3124

Closed obydog002 closed 4 months ago

obydog002 commented 4 months ago

Add tests for ReplayCardController

withThreeTeamsShowClickForMore is intermittently failing, think its an issue with a race condition but unsure how to fix

obydog002 commented 4 months ago

Removed the intermittent test, let me know if there is any else I should test

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (382a5f3) 58.92% compared to head (e98c55c) 59.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3124 +/- ## ============================================= + Coverage 58.92% 59.40% +0.48% - Complexity 4481 4506 +25 ============================================= Files 574 574 Lines 20535 20535 Branches 1019 1019 ============================================= + Hits 12100 12199 +99 + Misses 7900 7797 -103 - Partials 535 539 +4 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../faforever/client/replay/ReplayCardController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9yZXBsYXkvUmVwbGF5Q2FyZENvbnRyb2xsZXIuamF2YQ==) | `82.24% <ø> (+82.24%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3124/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3124?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3124?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [382a5f3...e98c55c](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3124?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).