search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Migrate to using monos from api calls #3136

Closed Sheikah45 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 78.80623% with 245 lines in your changes are missing coverage. Please review.

Project coverage is 59.46%. Comparing base (ab3e9bf) to head (13338f0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3136 +/- ## ============================================= + Coverage 59.40% 59.46% +0.05% + Complexity 4512 4463 -49 ============================================= Files 574 574 Lines 20541 20601 +60 Branches 1019 1012 -7 ============================================= + Hits 12203 12251 +48 - Misses 7800 7810 +10 - Partials 538 540 +2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...in/java/com/faforever/client/coop/CoopService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BTZXJ2aWNlLmphdmE=) | `91.66% <100.00%> (-2.78%)` | :arrow_down: | | [...m/faforever/client/fa/relay/ice/CoturnService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9mYS9yZWxheS9pY2UvQ290dXJuU2VydmljZS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...orever/client/filter/ChatUserFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvQ2hhdFVzZXJGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `86.00% <100.00%> (+1.90%)` | :arrow_up: | | [...ver/client/filter/CustomGamesFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvQ3VzdG9tR2FtZXNGaWx0ZXJDb250cm9sbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...ava/com/faforever/client/filter/FilterBuilder.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvRmlsdGVyQnVpbGRlci5qYXZh) | `100.00% <100.00%> (ø)` | | | [...rever/client/filter/LiveGamesFilterController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9maWx0ZXIvTGl2ZUdhbWVzRmlsdGVyQ29udHJvbGxlci5qYXZh) | `81.25% <100.00%> (+1.25%)` | :arrow_up: | | [...ver/client/fx/contextmenu/OpenClanUrlMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9PcGVuQ2xhblVybE1lbnVJdGVtLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...textmenu/SendPrivateMessageClanLeaderMenuItem.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9jb250ZXh0bWVudS9TZW5kUHJpdmF0ZU1lc3NhZ2VDbGFuTGVhZGVyTWVudUl0ZW0uamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...om/faforever/client/game/GameDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVEZXRhaWxDb250cm9sbGVyLmphdmE=) | `94.65% <100.00%> (-0.05%)` | :arrow_down: | | [.../com/faforever/client/map/MapDetailController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwRGV0YWlsQ29udHJvbGxlci5qYXZh) | `87.70% <100.00%> (+0.06%)` | :arrow_up: | | ... and [46 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [ab3e9bf...13338f0](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3136?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).