search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Clean up leaderboard UI code #3138

Closed Sheikah45 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 85.85132% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 59.59%. Comparing base (b77511d) to head (d06bc81).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3138 +/- ## ============================================= + Coverage 59.46% 59.59% +0.13% - Complexity 4464 4467 +3 ============================================= Files 574 576 +2 Lines 20609 20677 +68 Branches 1011 1005 -6 ============================================= + Hits 12255 12323 +68 - Misses 7815 7828 +13 + Partials 539 526 -13 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...a/com/faforever/client/domain/LeagueEntryBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vTGVhZ3VlRW50cnlCZWFuLmphdmE=) | `78.94% <100.00%> (ø)` | | | [...a/com/faforever/client/domain/SubdivisionBean.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vU3ViZGl2aXNpb25CZWFuLmphdmE=) | `83.33% <ø> (+3.33%)` | :arrow_up: | | [.../main/java/com/faforever/client/fx/JavaFxUtil.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9meC9KYXZhRnhVdGlsLmphdmE=) | `59.42% <100.00%> (+0.79%)` | :arrow_up: | | [...forever/client/leaderboard/LeaderboardService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sZWFkZXJib2FyZC9MZWFkZXJib2FyZFNlcnZpY2UuamF2YQ==) | `99.21% <100.00%> (-0.14%)` | :arrow_down: | | [...ava/com/faforever/client/player/PlayerService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wbGF5ZXIvUGxheWVyU2VydmljZS5qYXZh) | `75.00% <100.00%> (+0.68%)` | :arrow_up: | | [...r/client/player/UserLeaderboardInfoController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9wbGF5ZXIvVXNlckxlYWRlcmJvYXJkSW5mb0NvbnRyb2xsZXIuamF2YQ==) | `94.28% <100.00%> (+0.34%)` | :arrow_up: | | [...ent/teammatchmaking/PartyMemberItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvUGFydHlNZW1iZXJJdGVtQ29udHJvbGxlci5qYXZh) | `82.60% <100.00%> (+0.19%)` | :arrow_up: | | [...ent/teammatchmaking/TeamMatchmakingController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nQ29udHJvbGxlci5qYXZh) | `85.34% <100.00%> (+0.07%)` | :arrow_up: | | [...java/com/faforever/client/chat/ChatController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDb250cm9sbGVyLmphdmE=) | `32.14% <0.00%> (ø)` | | | [...ver/client/leaderboard/LeaderboardsController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sZWFkZXJib2FyZC9MZWFkZXJib2FyZHNDb250cm9sbGVyLmphdmE=) | `95.65% <87.50%> (-0.27%)` | :arrow_down: | | ... and [4 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [b77511d...d06bc81](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).