search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Make api objects immutable #3140

Closed Sheikah45 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 72.53470% with 376 lines in your changes are missing coverage. Please review.

Project coverage is 58.73%. Comparing base (05eea7a) to head (cfa3fd1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3140 +/- ## ============================================= - Coverage 59.54% 58.73% -0.82% + Complexity 4465 3990 -475 ============================================= Files 576 574 -2 Lines 20677 19203 -1474 Branches 1005 1013 +8 ============================================= - Hits 12312 11278 -1034 + Misses 7837 7433 -404 + Partials 528 492 -36 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../java/com/faforever/client/api/FafApiAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `90.12% <100.00%> (+0.06%)` | :arrow_up: | | [.../main/java/com/faforever/client/avatar/Avatar.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hdmF0YXIvQXZhdGFyLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...ava/com/faforever/client/avatar/AvatarService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hdmF0YXIvQXZhdGFyU2VydmljZS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...ava/com/faforever/client/chat/ChatChannelUser.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRDaGFubmVsVXNlci5qYXZh) | `90.90% <100.00%> (ø)` | | | [...m/faforever/client/chat/ChatMessageController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0NoYXRNZXNzYWdlQ29udHJvbGxlci5qYXZh) | `79.89% <100.00%> (-0.33%)` | :arrow_down: | | [...a/com/faforever/client/chat/KittehChatService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L0tpdHRlaENoYXRTZXJ2aWNlLmphdmE=) | `72.76% <100.00%> (-0.11%)` | :arrow_down: | | [...forever/client/chat/MatchmakingChatController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L01hdGNobWFraW5nQ2hhdENvbnRyb2xsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...aforever/client/chat/PrivateChatTabController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jaGF0L1ByaXZhdGVDaGF0VGFiQ29udHJvbGxlci5qYXZh) | `100.00% <100.00%> (ø)` | | | [...in/java/com/faforever/client/clan/ClanService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jbGFuL0NsYW5TZXJ2aWNlLmphdmE=) | `71.42% <100.00%> (-3.58%)` | :arrow_down: | | [...a/com/faforever/client/domain/api/CoopMission.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vYXBpL0Nvb3BNaXNzaW9uLmphdmE=) | `100.00% <100.00%> (ø)` | | | ... and [176 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [05eea7a...cfa3fd1](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3140?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).