search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Simplify Mappers #3141

Closed Sheikah45 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.26316% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 58.70%. Comparing base (021f3aa) to head (a3f08fc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3141 +/- ## ============================================= - Coverage 58.76% 58.70% -0.06% + Complexity 3990 3955 -35 ============================================= Files 574 573 -1 Lines 19198 19164 -34 Branches 1013 1013 ============================================= - Hits 11282 11251 -31 + Misses 7424 7423 -1 + Partials 492 490 -2 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...ava/com/faforever/client/avatar/AvatarService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hdmF0YXIvQXZhdGFyU2VydmljZS5qYXZh) | `100.00% <100.00%> (ø)` | | | [...in/java/com/faforever/client/clan/ClanService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jbGFuL0NsYW5TZXJ2aWNlLmphdmE=) | `66.66% <100.00%> (-4.77%)` | :arrow_down: | | [...in/java/com/faforever/client/coop/CoopService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9jb29wL0Nvb3BTZXJ2aWNlLmphdmE=) | `72.72% <100.00%> (-1.19%)` | :arrow_down: | | [...ain/java/com/faforever/client/domain/api/Clan.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vYXBpL0NsYW4uamF2YQ==) | `100.00% <ø> (+33.33%)` | :arrow_up: | | [...va/com/faforever/client/domain/api/ModVersion.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vYXBpL01vZFZlcnNpb24uamF2YQ==) | `100.00% <ø> (ø)` | | | [...forever/client/leaderboard/LeaderboardService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9sZWFkZXJib2FyZC9MZWFkZXJib2FyZFNlcnZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...ava/com/faforever/client/mapstruct/ClanMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvQ2xhbk1hcHBlci5qYXZh) | `0.00% <ø> (-75.00%)` | :arrow_down: | | [...ava/com/faforever/client/mapstruct/GameMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvR2FtZU1hcHBlci5qYXZh) | `57.14% <ø> (-5.36%)` | :arrow_down: | | [...om/faforever/client/mapstruct/IceServerMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvSWNlU2VydmVyTWFwcGVyLmphdmE=) | `100.00% <ø> (ø)` | | | [...java/com/faforever/client/mapstruct/MapMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvTWFwTWFwcGVyLmphdmE=) | `75.00% <100.00%> (ø)` | | | ... and [14 more](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [021f3aa...a3f08fc](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3141?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).