search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Feature/#2319 veto system: simple maplist popup #3151

Closed K-ETFreeman closed 2 months ago

K-ETFreeman commented 3 months ago

"Maplist" button on the Play tab now summons popup with maplist instead of navigating to the vault. This is "Simple" version of the popup, shows maps without duplicates, with grayscaling of map tiles

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 5.44218% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 58.19%. Comparing base (dd9ab2b) to head (12aaf8c). Report is 2 commits behind head on develop.

:exclamation: Current head 12aaf8c differs from pull request most recent head 331dfe0. Consider uploading reports for the commit 331dfe0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3151 +/- ## ============================================= - Coverage 58.83% 58.19% -0.64% + Complexity 3984 3951 -33 ============================================= Files 576 575 -1 Lines 19296 19279 -17 Branches 1022 1025 +3 ============================================= - Hits 11353 11220 -133 - Misses 7447 7569 +122 + Partials 496 490 -6 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [.../java/com/faforever/client/api/FafApiAccessor.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fapi%2FFafApiAccessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9hcGkvRmFmQXBpQWNjZXNzb3IuamF2YQ==) | `90.12% <100.00%> (-0.07%)` | :arrow_down: | | [...ever/client/domain/api/MatchmakerQueueMapPool.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fdomain%2Fapi%2FMatchmakerQueueMapPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vYXBpL01hdGNobWFrZXJRdWV1ZU1hcFBvb2wuamF2YQ==) | `100.00% <ø> (ø)` | | | [...main/java/com/faforever/client/map/MapService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fmap%2FMapService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwU2VydmljZS5qYXZh) | `69.65% <100.00%> (-2.19%)` | :arrow_down: | | [.../faforever/client/vault/VaultEntityController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fvault%2FVaultEntityController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC92YXVsdC9WYXVsdEVudGl0eUNvbnRyb2xsZXIuamF2YQ==) | `39.76% <100.00%> (ø)` | | | [...a/com/faforever/client/map/MapVaultController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fmap%2FMapVaultController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXAvTWFwVmF1bHRDb250cm9sbGVyLmphdmE=) | `71.95% <0.00%> (+4.13%)` | :arrow_up: | | [...eammatchmaking/MatchmakingQueueItemController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fteammatchmaking%2FMatchmakingQueueItemController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvTWF0Y2htYWtpbmdRdWV1ZUl0ZW1Db250cm9sbGVyLmphdmE=) | `77.64% <0.00%> (-4.29%)` | :arrow_down: | | [...ent/teammatchmaking/TeamMatchmakingController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fteammatchmaking%2FTeamMatchmakingController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nQ29udHJvbGxlci5qYXZh) | `79.10% <6.66%> (-5.85%)` | :arrow_down: | | [...mmatchmaking/TeamMatchmakingMapTileController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fteammatchmaking%2FTeamMatchmakingMapTileController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nTWFwVGlsZUNvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...mmatchmaking/TeamMatchmakingMapListController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fteammatchmaking%2FTeamMatchmakingMapListController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC90ZWFtbWF0Y2htYWtpbmcvVGVhbU1hdGNobWFraW5nTWFwTGlzdENvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [e1ed832...331dfe0](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3151?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
K-ETFreeman commented 2 months ago

Hi @Sheikah45 , some adjustments were made, i think it can be reviewed once more

Sheikah45 commented 2 months ago

Also I would make an observable value queue.map(Queue::getLeaderboard) so that null exceptions with queues can be avoided