search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Change text on search button #3157

Closed BlackYps closed 2 months ago

BlackYps commented 2 months ago

Changes the text on the search button that is used in the matchmaker tab. Apparently people regularly don't realize that they need to press this button to actually start searching, so the text is more explicit now.

Btw, do existing translations automatically get some sort of mark that the original text has changed and they need retranslation?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.86%. Comparing base (60c84a7) to head (de3d17d).

:exclamation: Current head de3d17d differs from pull request most recent head d8b44d2. Consider uploading reports for the commit d8b44d2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3157 +/- ## ============================================= + Coverage 58.84% 58.86% +0.02% Complexity 3986 3986 ============================================= Files 576 576 Lines 19296 19290 -6 Branches 1022 1019 -3 ============================================= + Hits 11355 11356 +1 + Misses 7446 7439 -7 Partials 495 495 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3157/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3157?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3157?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [60c84a7...d8b44d2](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3157?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
Sheikah45 commented 2 months ago

They do not that is why a new key should be used instead of reusing an old one.