search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Token invalid on every login #3164

Open Kardix opened 2 months ago

Kardix commented 2 months ago

Hello,

I've been having an issue - namely the token expiring. WHile i totally understand why (oauth and oauth2 principles) - why can't the app use refresh token to refresh the token, and instead makes user re-login on the page ? I'm assuming it's the FAF_windows_x64_2024_3.0 version

To Reproduce Invalidate token & start the app i guess.

*edit: Or be in app and have it expire. Will actually brick the game.

Log or error message Will update on next exception, already logged in, perhaps tomorrow *edit - token lifetime = 5h

Expected behavior A user is logged in, without being told his token is malformed, expired or whatnot.

*edit: ALSO not stopping the game, because someone's token has expired

Screenshots N/A

OS Windows

Sheikah45 commented 2 months ago

If you get this error on first login then it is the refresh token that is expired for some reason likely it was used and the client had issues updating the prefs file likely because of permissions.

Kardix commented 2 months ago

@Sheikah45 hey, i was in game actually and the token expired in 5h. THis resulted in game hanging, and the app telling me token is invalid malformed or expired, and causing the game to stop for all players

Sheikah45 commented 2 months ago

hmm yeah that is pretty weird. But that message is basically saying the refresh token itself is invalid