FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Date language mixup #3176

Closed Backspace345 closed 2 weeks ago

Backspace345 commented 1 month ago

Describe the bug In leaderboards tab the current season period is shown in French, while client language is set to English. Changing client language doesn't change date language in leaderboards. Date format in settings is set to Day/Month/Year, if that's related.

To Reproduce Go to settings > appearance, set date format to Day/Month/Year, go to Leaderboards tab.

Expected behavior Dates changing according to client language.

Screenshots 1

OS Windows 10

Sheikah45 commented 1 month ago

This is an artifact of the time locale being able to be set independently of the language in settings.

magge-faf commented 1 month ago

FYI: In the context of 'mai', 'juin' is most likely French.

Backspace345 commented 1 month ago

FYI: In the context of 'mai', 'juin' is most likely French.

Thanks! Post updated

sulikdan commented 1 month ago

@Sheikah45 Were you able to reproduce it by description? I tried to look into, but the date is following a user's setting of preferred language. Tried multiple combination.

@Backspace345 If you change a language(to somethign different) and restart the client, is it still same? Do you still get french one? Even when you get back to origin language?

Tested on Win11.

Backspace345 commented 1 month ago

@sulikdan yes, tried multiple times now, for some reason it just stays there. Complete reinstall removed the bug though. I wonder if it's because my windows install broke once. Due to that i had to reformat drive with it, which apparently contained some of the metadata client files, but the client itself was installed on a separate drive, and after reinstalling windows i just went to the client folder and created a shortcut manually. Surprisingly enough it worked just fine. So i guess there never was any issue?

Sheikah45 commented 1 month ago

Yes it is because of this setting being not auto image

Backspace345 commented 1 month ago

Yes it is because of this setting being not auto image

Can confirm, this is what causing it. Surprisingly setting date format to Month/Day/Year doesn't do it. Post updated

sulikdan commented 1 month ago

@Sheikah45 can I take it?

Sheikah45 commented 1 month ago

In terms of fixing it sure.