search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Add lifetime of lobby in games table #3198

Closed Marc-Spector closed 3 weeks ago

Marc-Spector commented 4 weeks ago

Requests https://github.com/FAForever/faf-java-commons/pull/152 Closes #3054 image

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.47%. Comparing base (dd9ab2b) to head (949a3d2). Report is 26 commits behind head on develop.

:exclamation: Current head 949a3d2 differs from pull request most recent head 07eea84

Please upload reports for the commit 07eea84 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3198 +/- ## ============================================= - Coverage 58.83% 58.47% -0.36% - Complexity 3984 4089 +105 ============================================= Files 576 581 +5 Lines 19296 19790 +494 Branches 1022 1035 +13 ============================================= + Hits 11353 11573 +220 - Misses 7447 7712 +265 - Partials 496 505 +9 ``` | [Files](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) | Coverage Δ | | |---|---|---| | [...om/faforever/client/game/GamesTableController.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fgame%2FGamesTableController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9nYW1lL0dhbWVzVGFibGVDb250cm9sbGVyLmphdmE=) | `50.00% <66.66%> (+0.43%)` | :arrow_up: | | [...a/com/faforever/client/domain/server/GameInfo.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fdomain%2Fserver%2FGameInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9kb21haW4vc2VydmVyL0dhbWVJbmZvLmphdmE=) | `88.52% <60.00%> (-1.22%)` | :arrow_down: | | [...ava/com/faforever/client/mapstruct/GameMapper.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Fmapstruct%2FGameMapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC9tYXBzdHJ1Y3QvR2FtZU1hcHBlci5qYXZh) | `50.00% <0.00%> (-7.15%)` | :arrow_down: | | [...in/java/com/faforever/client/util/TimeService.java](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fcom%2Ffaforever%2Fclient%2Futil%2FTimeService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever#diff-c3JjL21haW4vamF2YS9jb20vZmFmb3JldmVyL2NsaWVudC91dGlsL1RpbWVTZXJ2aWNlLmphdmE=) | `39.39% <77.77%> (+39.39%)` | :arrow_up: | ... and [15 files with indirect coverage changes](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Last update [8a4b1ab...07eea84](https://app.codecov.io/gh/FAForever/downlords-faf-client/pull/3198?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FAForever).
Marc-Spector commented 3 weeks ago

The only thing that gives me a little pause is that the lifetime column is static so won't actually be updated unless we get an update from the game.

Or we can switch to another tab and then back again to get the fresh result. Sorting the lifetime column. And much more

Part of me wonders if it should be guaranteed to be updated.

That's up to you. If it's necessary, then I need to figure out how to do it.

Sheikah45 commented 3 weeks ago

Yeah I guess if it updates that often then we will just see if anyone complains about it