search

FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
194 stars 117 forks source link

Remember last opened chat tab #3205

Closed Marc-Spector closed 1 week ago

Marc-Spector commented 2 weeks ago

Since the main tabs are now recreated with each click, the last opened chat tab of the channel or player is no longer remembered. This pull request will help bring this feature back.

Marc-Spector commented 2 weeks ago

At a high level this makes sense.

I just wonder if we could just use a map or something in Chat navigation instead of a list of a new class.

When creating the ChatTab class I assumed that in the future there would be other variables that could be added. For example, lastVisibleMessageIndex variable if the user scrolls up and goes to another main tab and then returns to the chat in the same place. This is just a rough example.

Sheikah45 commented 2 weeks ago

Fair I suppose. Although the last visible message is stored in the Chat channel object now just as FYI