Feature: Sound for match found

FAForever / downlords-faf-client

Official client for Forged Alliance Forever

https://faforever.com

MIT License

196 stars 121 forks source link

Feature: Sound for match found #3216

Closed DotNetSimon closed 3 months ago

DotNetSimon commented 3 months ago

Added a new sound when the match-found notification triggers. It is like a simple beep-beep-beep-beep race start sound, not too intrusive but clear.

Added notification to enable/disable it (on by default).
Added tests for sound playing as with other sounds.

Manual tests done: ✅ Check labels/checkboxes are ok in English. ✅ Check checkbox functions (on/off) ✅ Check sound plays when match is found [ ] Check default settings show correctly in settings - notifications window (not sure how to reset settings...)

Not sure how to add all the translations? Used the same words as for the "Match Found" string, so it should be easy to add these.

Fixes https://github.com/FAForever/downlords-faf-client/issues/2984

Sheikah45 commented 3 months ago

You can check the default settings by just renaming your client.prefs file

BlackYps commented 3 months ago

Someone found a nice sound here: https://github.com/FAForever/downlords-faf-client/issues/2984 We should use that

Sheikah45 commented 3 months ago

Right now the tests are failing because the notificationPrefs object wasn't added to the test.

Additionally the if check around the playMatchSound is a little redundant since it checks inside the audio service

DotNetSimon commented 3 months ago

Someone found a nice sound here: #2984 We should use that

I've used this new sound. I think it might be more intrusive/disruptive than the one I was using before but if anyone asks I'll send them to you 👍

DotNetSimon commented 3 months ago

Right now the tests are failing because the notificationPrefs object wasn't added to the test.

Additionally the if check around the playMatchSound is a little redundant since it checks inside the audio service

Fixed both.

DotNetSimon commented 3 months ago

@BlackYps can you try with that sound? It is quite loud and it will scare people shitless when it suddenly blares after 30 minutes of not paying attention :p

The sound I used originally is more kind to the ears.

https://pixabay.com/sound-effects/countdown-sound-effect-8-bit-151797/

It's Pixabay which we already use.

DotNetSimon commented 3 months ago

I've reused the sound from Warren that was lowered by 8db and it's pretty good now. Let me know if there's anything else to adjust @Sheikah45