FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
198 stars 121 forks source link

[Bug]: Map Generation fails for some combinations of Number of Teams and Symmetry type #3273

Open obydog002 opened 1 week ago

obydog002 commented 1 week ago

Describe the Bug

generation

With a configuration like the above the map generation fails silently.

Log file or Error Message

Silently fails

Reproduce the bug

Some combinations I tried that dont work:

Expected Behavior

Granted I don't expect for example 2 teams with 5 symmetry to generate a balanced map, so if its impossible the map gen dialog should disable the 'incompatible' options or disappear them, similar to how Spawns and Teams are linked. But I cant see why for example 4 teams, POINT2 symmetry shouldn't work

If they should be generating then the underlying issue should be fixed. I'd prefer they generate even if results in a unbalanced map.

Screenshots

No response

Additional context

No response

Which Operating System are you using?

Linux

Sheikah45 commented 1 week ago

The map generator can only generate maps when the number of teams is a factor of the number of symmetry points.

Really the symmetry setting is an advanced option that shouldn't really be shown by default because of this.

obydog002 commented 1 week ago

Yea, makes sense. Too bad for the 3 teams 7 symmetry maps XD

Then its okay if it would just disable or remove the options if they are incompatible.

Sheikah45 commented 1 week ago

The issue is that the client only knows the name of the symmetries not their compatibility with the number of teams