FAForever / downlords-faf-client

Official client for Forged Alliance Forever
https://faforever.com
MIT License
196 stars 121 forks source link

UI crashes when starting it with java.exe because missing install4j #821

Closed germanicianus closed 6 years ago

germanicianus commented 6 years ago

Workaround is to comment the following line in MainController.java: noCatch(SplashScreen::hide);

This is the one and only place where install4j is referenced in the code.

1-alex98 commented 6 years ago

But do we wanna support starting it that way, I would say we dont care

Geosearchef commented 6 years ago

We do wanna support starting it without Install4J, but that has very low priority. I had a discussion with downlord on this, we shouldn't invest into linux compatibility, but the client has already come a long way and is only missing packaging steps and some minor fixes to be fully linux compatible. So I'd say we care. If you wanna discuss if we'll do this please move to slack.

micheljung commented 6 years ago

Try to load the class via classloader (Class.forName()), if it's there execute the code else don't