FAForever / dserver

5 stars 0 forks source link

games closed command sending unnecesary data #2

Open spooky opened 9 years ago

spooky commented 9 years ago

The games closed event sends a whole bunch of data that is not really necessary - sending just the id should be enough.

Eximius commented 9 years ago

It is an interesting discussion.

Basically, current system allows last chance information grabbing for a closed game without sending a weirdly placed update message.

Whenever a game is closed you can be sure you had the correct information when it was. You could say you do not need that information, because the object was destroyed and the connected data is not (and will not be) relevant any more and that is a fair assumption in our use case.

It is only a redundancy that doesn't incur any extra cost (other than a few more kbits on game close). We can easily turn it off whenever.