FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Third row for cybran economy UI #3394

Closed Garanas closed 2 years ago

Garanas commented 2 years ago

image

The image speaks for itself. This only happens on FAFDevelop and only for the cybran UI. You can switch the theme with alt + left / right arrow.

With thanks to WhenDayBreaks for investigating the issue.

Garanas commented 2 years ago

I can only reproduce this when it is launched through the client. Running on FAF Develop with my development environment makes this issue impossible to reproduce.

Garanas commented 2 years ago

Launched through client with develop branch: image

Launched locally with (latest) develop branch: image

What is the difference? The code that is being run should be the same. What am I missing here?

KionX commented 2 years ago

Not reproduce anyway. This is a different texture. Maybe mods, others .nx5 .scd .nxt

Garanas commented 2 years ago

Several people have had this issue - I made sure there were no mods on when I tried it myself.

Tagada14 commented 2 years ago

I can reproduce it as well.

KionX commented 2 years ago

Maybe this will help: UI_Lua WARN(repr(import('/lua/ui/game/economy.lua').GUI.bg.panel._filename))

Garanas commented 2 years ago

image

Which is a file part of the base game.

image

Which appears to be fine.

image

KionX commented 2 years ago

I believe that this means that the code has not been changed. It looks like the case is in some archive changed bmp. Mostly a suspicion of *.nxt

Garanas commented 2 years ago

Those textures are not part of the repo:

image

But it has to come from somewhere.

KionX commented 2 years ago

whitelist in init_faf. lua and init_fafdevelop.lua is different. init_fafdevelop. lua contains a non-existent file props.nx5 instead of modules.nx5 I don't know if this is related to the problem.

Garanas commented 2 years ago

I don't think that is it. The modules folder is essentially gaz_ui, which has a .nxt2 and .nxt5 version on my system. Pretty identical and I think it is unrelated to the score board. Where does the modules zip files come from? They're not part of the repository as far as I can see.

Garanas commented 2 years ago

I'll do a binary search tonight to find the PR that did this.

4z0t commented 2 years ago

I think its already solved

Garanas commented 2 years ago

Yes - it was due to a mod in the era where we allowed mods to load in any textures 😄