search

FAForever / fa

Lua code for FAF
228 stars 234 forks source link

Refactor lobby code #38

Closed Sheeo closed 10 years ago

Sheeo commented 10 years ago

At the moment, the lobby code has grown out of proportion.

There are 7.200 lines of ill-formatted and inconsistent lua code. This needs fixing.

Crotalus commented 10 years ago

Yes, this will break all lobby mods though but I guess it's worth it

Sheeo commented 10 years ago

Yeah every update of the lobby seems to do that anyway...

We'd get a proper API that can be modded out of it, so it's a win win for this.

Crotalus commented 10 years ago

I suggest someone with alot of UI programming experience ( @thygrrr ?) make the base structure for the lobby, event listeners etc. Then someone can do the grunt work with hooking that up to the current lobby gfx/elements so it works somewhat like the current lobby.

Sheeo commented 10 years ago

I think @thygrrr has enough work with the lobby.

I'll take this on in time. It's not that complex :)

thygrrr commented 10 years ago

Well actually once I get done with the patcher I want to do just that.

I want this to be roughly in line with what eximius built, though naming conventions may differ slightly.

I want all the logic components talk to the UI Views/Controllers via signals/slots.

thygrrr commented 10 years ago

Let's get aligned on this tomorrow OK? Better share the work so more people have a sense of ownership.

Sheeo commented 10 years ago

@thygrrr we're talking ingame lobby here, is that what you mean?

Sure, I'll be online tomorrow.

thygrrr commented 10 years ago

Oops. Nevermind then :) Guess I shouldn't be answering tickets while at a rock concert.

Sheeo commented 10 years ago

Closing this, since we're going in a different direction in the future. Saves us a lot of work here :)