search

FAForever / fa

Lua code for FAF
229 stars 234 forks source link

Assisted Mexes Showing Progress When Paused #4551

Closed Spikey84 closed 1 year ago

Spikey84 commented 1 year ago

Describe the bug When a mexes is paused after the upgrade is started the progress bar will not be filled. This becomes an issue when assisting paused mexes. They will indicate the progress from when they were paused rather than the assisted progress.

To Reproduce Start a mex upgrade, pause it, assist with an engi, and watch as progress bar does not update.

Expected behavior The progress bar should update along with the assistance regardless of paused status.

Screenshots image Notice that the ACU indicates a progress of 50% while the mex shows 0-1%.

Additional context image The same issue happens when doing the exact same thing with factories. Seems not to be an issue for Tacs/SMD.

I always assumed this could not be fixed. But if it can be it would hugely improve the quality of life when ecoing. Thanks for everyone's work!

4z0t commented 1 year ago

@Garanas is progress bar controlled by the engine? If it is then engine fix required.

Spikey84 commented 1 year ago

Seems up @KionX's alley.

Garanas commented 1 year ago

https://user-images.githubusercontent.com/15778155/210508898-9cad951f-e4cf-4b5c-8aea-5d94612dabdf.mp4

Both - Lua can control it too. I'll leave it up to Kionx to determine whether an engine patch is better. From a Lua perspective it isn't a lot of code, and it doesn't cost us anything either.

KionX commented 1 year ago

I'll take a look at this.

Garanas commented 1 year ago

@Spikey84 KionX made an engine patch, and that is now deployed. Can you test it, by hosting a game on FAFDevelop via the client?

Garanas commented 1 year ago

This is fixed with thanks to the engine patch.