FAForever / fa

Lua code for FAF
229 stars 234 forks source link

SACUs Do Not Retain Upgrades When Gifted #5233

Open ComradeStryker opened 1 year ago

ComradeStryker commented 1 year ago

Describe the bug Presets work just fine, but changing any upgrade or adding a new upgrade, anything that isn't preset change, does not retain when you gift the unit to a teammate.

This works both ways. Obtained upgrades are reverted, and removed upgrades are reapplied.

In short, the unit reverts to the preset it was. Basic/Standard, Rambo, RAS, Engineer, etc.


To Reproduce Sandbox Game:


Expected behavior Upgrades are retained properly when SACUs are gifted over.

Garanas commented 1 year ago

This is intended at the moment. There was a bug with SACUs being able to have double enhancements by gifting them otherwise.

ChessBerry commented 6 months ago

The same happened in this faf-dev game: 22410511 when I died at ~44:20 and my poor tele sacu lost all his upgrades after being transferred to foley 😢

Is it better to remove upgrades on gifting, potentially punishing poor, innocent sacus that have done no wrong, than it would be to to keep the upgrades on transfer while explicitly forbidding the use of this exploit?