search

FAForever / fa

Lua code for FAF
228 stars 234 forks source link

Game time bug in replays in chat window #5238

Open magge-faf opened 1 year ago

magge-faf commented 1 year ago

Describe the bug

Since the last patch, I have frequently encountered a bug in the game time for replays, as shown below:

image

image

Example replay IDs:

20396409 20395017 20389399

To Reproduce

  1. Start FAF
  2. Search for any example replay ID from above
  3. Click on 'Download more information'
  4. Scroll the chat log until you spot the bug
Garanas commented 1 year ago

🤔 , is this a bug in the game or in the client?

magge-faf commented 1 year ago

The moderation tool throws an exception error for the 'minus game time', when people report a game ID with a bugged chat, so I think it is not related to the client or the moderation tool, but to the content of the replay file, I believe.

Because I saw the bug since the last big patch, I thought it had something to do with it.

Unfortunately, I don't know how to reproduce those false time codes.

Garanas commented 1 year ago

Would you happen to know where these timestamps are read from the replay by either the user or moderator client?

magge-faf commented 1 year ago

I am not familiar with the replay-stuff and have only found the following related to the client itself: https://github.com/FAForever/downlords-faf-client/blob/6a1596c2e7c49e99f512f0ce0f9cb10b12d988f4/src/main/java/com/faforever/client/domain/ReplayBean.java#L34

and some ReplayDataParser here:

https://github.com/FAForever/faf-java-commons/blob/4a3facc8247309596d0cfe18acd1a32ede4c1e82/faf-commons-data/src/main/java/com/faforever/commons/replay/ReplayDataParser.java#L35