FAForever / fa

Lua code for FAF
226 stars 233 forks source link

Not reproducible: Beam weapons can still miss the Mantis and other units #5768

Open Basilisk3 opened 9 months ago

Basilisk3 commented 9 months ago

I cannot reproduce this, even with gifted units like in the replay.

Units, that I can confirm are affected by this:

Example: Replay ID: 21471096 Timestamp: 9:15, watch Swatoslav's first Tech 2 PDs in his mid base.

Another example: Replay ID: 21498203 Timestamp: 12:40 Watch the first Tech 2 PD's built to defend against Paralon's push. If you watch closely, you will notice that they excessively miss both Mantis and Medusas. Note that I am not talking about them hitting the terrain. The Ilshavohs can also be seen missing excessively.

Basilisk3 commented 9 months ago

It appears that this is not exclusive to the mantis and that it can happen to other units as well. I am guessing there is another bug at work here, because these units should have a sufficient Z-size already.

Basilisk3 commented 9 months ago

I also remember seeing this happen to the shard. @Garanas Shall we just increase the Z-size of these units, and see if this still happens?

Garanas commented 9 months ago

I'm not sure. If it is trivial to reproduce then yes, but for rare edge cases I don't think we should keep increasing the size of the collision boxes.

The Shard still has some spare room, you can increase that by one or more one tents!

Basilisk3 commented 9 months ago

It is not reproducible, but I have seen it multiple times now (at least with the Mantis). In case I see it in more replays, I will post those too.

Basilisk3 commented 7 months ago

This is probably related to this:

https://github.com/FAForever/fa/issues/5742#issuecomment-1858836306