FAForever / fa

Lua code for FAF
223 stars 230 forks source link

Log re-added achievement values at end of game only #6058

Closed lL1l1 closed 4 months ago

lL1l1 commented 4 months ago

Description of the proposed changes

Resolves https://github.com/FAForever/fa/commit/a1327004af5faf998a96c63f41261ece16de0f2d#commitcomment-140697683 Only log the re-added achievement categories at the end of the game.

Testing done on the proposed changes

Add LOG(repr(ArmyScore)) after GameOverScore https://github.com/FAForever/fa/blob/0944ed698af1e8187afe2f5a0cec0b2cb4aac491/lua/sim/score.lua#L344-L347

Spawn SACUs, build an air factory, and build some tech 1 and tech 2 transports from it. Press end game in the main menu. The log should show how many SACU were spawned, how many transports were built, how many engineers there are (SACUs + 1 ACU), and the number of units for each tech tier.

Checklist

Garanas commented 4 months ago

Great find 👍 , that's a lot better 😄 !