Units are dying when being dropped on the reclaim

FAForever / fa

Lua code for FAF

223 stars 230 forks source link

Units are dying when being dropped on the reclaim #6076

Open K-ETFreeman opened 4 months ago

K-ETFreeman commented 4 months ago

Describe the bug Units are dying when being dropped on the reclaim

To Reproduce Drop some units on some reclaim (rocks for example or maybe even trees) Atleast works for sera engi when its dropped on platoe on adaptive rainy day (video)

Expected behavior Units dont die

https://github.com/FAForever/fa/assets/55841348/95402180-084a-4c73-acce-8c7173fa8cbe

Additional context Replay link is https://replay.faforever.com/22266592

lL1l1 commented 4 months ago

Perhaps it expected the unit to fall straight downards and not die hitting the rock, but new, faster transport behavior throws it onto the rock where it dies.

Garanas commented 4 months ago

To Reproduce Drop some units on some reclaim (rocks for example or maybe even trees) Atleast works for sera engi when its dropped on platoe on adaptive rainy day (video)

The large rocks block pathing, if the units ends up being dropped on such a location then they are instantly killed. It is engine behavior as far as I am aware. So it does not apply to trees or the smaller rocks, just the big ones and of course structures.

clyfordv commented 4 months ago

Transports come to a dead halt when they release units, while the units inherit whatever the speed of the transport was (god knows why). Setting the horizontal velocity of the units to zero would likely help them from being tossed into fatal places, though we might need to wait a tick to properly modify that value, for the usual reasons(?).