FAForever / fa

Lua code for FAF
223 stars 230 forks source link

Enable various structures to be placed more easily #6079

Closed Basilisk3 closed 4 months ago

Basilisk3 commented 4 months ago

Description of the proposed changes

The changes in this PR allow various units to accept higher variations in terrain. Resolves #6032.

I will go with a value of 1.2 for Game Enders and 1.1 for all other units. If the MaxGroundVariation field is not present in the blueprint, it defaults to 1.

Testing done on the proposed changes

Additional context

Possible since #4584, as structures do not deform the terrain underneath them as much anymore.

Checklist

Basilisk3 commented 4 months ago

@Garanas is there any point in changing the MaxGroundVariation for HQs?

lL1l1 commented 4 months ago

Placing HQs in cheat mode should be the same as support factories and t1 factories.

Garanas commented 4 months ago

Possible since #4584, as structures do not deform the terrain underneath them as much anymore.

Note that this change also improved the situation, it did not make it worse.

I agree with @lL1l1 , best to make them match up. All structures of an upgrade chain should have the same value

Basilisk3 commented 4 months ago

👍