Clean up various blueprints

FAForever / fa

Lua code for FAF

226 stars 233 forks source link

Clean up various blueprints #6081

Closed Basilisk3 closed 5 months ago

Basilisk3 commented 5 months ago

Description of the proposed changes

This PR attempts to remove the following fields from all blueprints:

BankingSlope = 0, MaxSteerForce = 0, MinSpeedPercent = 0, TurnRate = 0,

Testing done on the proposed changes

I have not found any issues with the functionality of the units.

Checklist

[x] Changes are documented in the changelog for the next game version

Garanas commented 5 months ago

How certain are we that these values are meaningless?

Basilisk3 commented 5 months ago

All units I tested still functioned normally. According to the debug dialog that lets you change units in-game, these stats all default to 0 if their respective fields are not present.

Garanas commented 5 months ago

@Basilisk3 can you update the changelog to the snippet format? Then we can merge this in

Basilisk3 commented 5 months ago

I added it in with the other two changes, is that correct?

Garanas commented 5 months ago

My mistake, I must have been confused!