Closed clyfordv closed 2 months ago
Fixed ctrl-k, probably had something to do with removing the part with comments to the effect of "do not remove this part or it won't work".
Please Request a review from me once PR is Complete :)
Alright we should be solid (tested it this time!)
Improvements:
TransportInternal
and TransportExternal
as damage types (currently only TransportInternal
is relevant, so we could trim it down to just Transport
if people like the simplicity).TransportInternal
damage type and will not play any effects, death threads, shield bounce projectiles, etc. when the internal storage they're in dies.Possible issues:
OnKilled
is not super strong, or at least not formalized. (For example, do death threads do anything that should still happen if killed inside a transport?)Minor issues:
deploy/fafdevelop
as well.Future ideas:
@relent0r will any of the changes here affect ai ?
I mediated on it for a bit, trimming down to a single damage type ("TransportDamage"
) felt right. Let me know if there's any objections.
@relent0r will any of the changes here affect ai ?
I don't see anything that would impact the default AI. The changing from OnKilled to Kill might impact other AI's that are tracking deaths of units. But it looks like we are trying to make it consistent between files so makes sense.
@lL1l1 you happy with the changes so far? if so can you approve the PR so I know
killedInTransport flagging variable is renamed back, so we should be squared away
VeterancyComponent.VeterancyDispersal
.And hopefully all in a much more straightforward way than before!