search

FAForever / fa

Lua code for FAF
226 stars 233 forks source link

SCU Changes #6092

Closed MrRowey closed 3 months ago

MrRowey commented 5 months ago

closes #6126

Checklist

All

UEF

Cybran

Aeon

Seraphim

Changelog

lL1l1 commented 5 months ago

When you get the final stats, let me know so that I can change the unit descriptions for the upgrades, since they have the stats written in them manually.

lL1l1 commented 4 months ago

Also it's generally better to have smaller commits detailing single changes instead of a large commit consisting of multiple changes. You have commit titles with a 3 item list separated by commas; that could be split up. It's a good idea to put the reasoning for a change in the commit description too, it will help write patch notes and show others your thoughts behind the changes.

MrRowey commented 4 months ago

Also it's generally better to have smaller commits detailing single changes instead of a large commit consisting of multiple changes. You have commit titles with a 3 item list separated by commas; that could be split up. It's a good idea to put the reasoning for a change in the commit description too, it will help write patch notes and show others your thoughts behind the changes.

I will update the commit description when I'm done