search

FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Improve area attack and reclaim orders #6095

Closed clyfordv closed 2 months ago

clyfordv commented 2 months ago

Click and drag to adjust the radius of area reclaim. Only works when in reclaim command mode.

arch625 commented 2 months ago

Could you attach a video clip showing the feature?

Garanas commented 2 months ago

@arch625

https://github.com/FAForever/fa/assets/15778155/0f993af6-da10-4185-8510-ceba818765cd

Garanas commented 2 months ago

Implementation of this article on Stack Overflow for ground attack and then distributing the orders:

https://github.com/FAForever/fa/assets/15778155/98c8d7dc-36a0-4512-992a-c05b235950b1

Because of the order of the points it looks messy 😃

Garanas commented 2 months ago

https://github.com/FAForever/fa/assets/15778155/42d692ba-724d-4a9e-8707-681c7a2b0642

RegalEagIe commented 2 months ago

Oh dear gog... This is amazing...

Garanas commented 2 months ago

https://github.com/FAForever/fa/assets/15778155/c6329112-b356-47ee-b94c-610588106bba

ChessBerry commented 2 months ago

Something changed in between implementations: With the one on the current commit, ea99794ce8bd264d39645eb1ff2cd96cccda327c, it's now seemingly not possible anymore to reclaim individual props w/o also ordering reclaim commands to everything around them.

With the one from a couple of days ago, 0b8523c4e6a1998f705019dffd2ff3a1507ccfea, this was possible.

Comparison, New vs Old: https://github.com/FAForever/fa/assets/90977374/e75bf300-4667-4dc4-90bd-acd6ba38c4e6

The ability to reclaim individual props w/o issuing an area reclaim command is pretty important for high level play and, even more significantly, it's necessary to get people to play on faf dev more than once.

Garanas commented 2 months ago

@ChessBerry great find; it's because I accidentally removed the minimum radius criteria which defaulted to 1. Which is the size of a wall. I'll add that back in