Closed lL1l1 closed 4 months ago
We recently introduced a test suite for invalid fire rates, see also;
Would you be interested to enhance the test suite to catch these cases too?
This isn't a balance change, its effect is only for the UI.
There's only 4 units with fire rate enhancements, does it need a test?
oh, I miss understood then. I thought this was a more broader problem! Great solution however 😃
This isn't a balance change, its effect is only for the UI.
you have changed a Unit Fire Rate tho so that is a balance Change
This isn't a balance change, its effect is only for the UI.
you have changed a Unit Fire Rate tho so that is a balance Change
If I'm not mistaken, practically it is the same value due to rounding 😃 ! It's now just more obvious what the value is.
It appears the tests do not run on this branch 🤔 , any idea as to why that is?
Not sure why it doesn't show up in the "checks" tab of the PR, but the tests do run on my fork's page https://github.com/lL1l1/fa/actions/workflows/test.yaml
That's gin then feel free to merge then when you happy jip
@lL1l1 is this ready for review
yes
Description of the proposed changes
Changes the UEF SACU's fire rate upgrade from 1.82 fire rate to 2.00 fire rate because
1/1.82 = 0.5494
so it rounds down to 0.5 fire delay, which is equal to 2 fire rate. Also updates the localizations.Testing done on the proposed changes
Spawn a UEF combatant preset and step 5 ticks while paused to confirm that it does shoot 2 times per second with the 1.82x fire rate.
Checklist