search

FAForever / fa

Lua code for FAF
226 stars 232 forks source link

Remove caching of the preference file #6124

Closed Garanas closed 5 months ago

Garanas commented 5 months ago

Description of the proposed changes

Fixes bugs that were introduced by #5871 . Caching the preference file is significant, but apparently the existing implementation introduces all sorts of buggy behavior.

Testing done on the proposed changes

Start a skirmish game, create a template and then start a new skirmish game in the same game session. The template should now still exist.

Try to change the resolution. The message to verify the changes should now pop up.

Additional context

It was apparently a greedy change of me 😃 and we should probably hot fix this.

Checklist

lL1l1 commented 5 months ago

Are the bugs from caching the pref file engine bugs? Templates not saving on session end sounds like prefs not saving on session end, which may be hookable with lua Exit.lua AddOnExitCallback.