FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Savegames get corrupted after the match goes on for a while #6133

Open Rikitik opened 2 months ago

Rikitik commented 2 months ago

after about 30 minutes saving a Skirmish match leaves an unusable savegame it will jus crash during loading, it seems to happen right before renderering. , Since all savegames after that point crash makes it seem like not a random occurencet It could be a time out issue or maybe something in the match happened that is not compatible with the original game engine which can not be saved

PS it happens on ALL maps

Garanas commented 2 months ago

🤔 , could you give us the lobby settings such as the enabled mods and the number of AIs and/or players? A replay would also be nice just to make sure that we can reproduce it properly.

Rikitik commented 2 months ago

The Map Crate Face 8 players(All Filled with M28AI-easy), setons quad 30km 16 players (All filled M28AI-easy) only 1-2 Mods M28AI/Nomad but without nomads it happens too

I have been testing without any mods no issues after 1 hour game So it may be an M28AI thing. The only illegal behavior i may have seen that can cause issues is that it places its first land factory next to a mex for adjacency bonus but somehow manages to also place 4 mass storages aound that mex(overlapping the land factory with a mass storage, which in my limited understand may cause an placement error during loading?

Garanas commented 2 months ago

If it only impacts M28AI then there's likely a cycle somewhere that prevents the (de)serialization of the Lua state. I've had the same issue with the navigational mesh that was originally one big cycle