Remove several unused fields from various blueprints

FAForever / fa

Lua code for FAF

226 stars 232 forks source link

Remove several unused fields from various blueprints #6161

Closed Basilisk3 closed 3 months ago

Basilisk3 commented 4 months ago

Description of the proposed changes

This PR removes the following fields from various blueprints: bp.General.TechLevel bp.General.Classification bp.General.Category bp.General.UnitWeight

Testing done on the proposed changes

All units I tested still functioned normally.

Additional context

According to an older Discord post by @The-Balthazar, these fields can be removed safely.

Checklist

[x] Changes are documented in the changelog for the next game version (in #6149).

The-Balthazar commented 4 months ago

I have always said that things relying on those fields are prone to the data being wrong because it's not actually used, and I think the fact that Spooky used to have to redefine the values of the Kennels is a prime example of that. But it's still important to make sure things aren't breaking.

Garanas commented 3 months ago

@Basilisk3 by merging in https://github.com/FAForever/fa/pull/6149 this pull request now has an infinite list of conflicts. Shall I close this pull request?

Basilisk3 commented 3 months ago

@Garanas Yes, I can remake it at a later date.