search

FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Remove even more unnecessary fields from various blueprints (bp.Defense) #6171

Closed Basilisk3 closed 2 weeks ago

Basilisk3 commented 1 month ago

Description of the proposed changes

This PR removes the following fields from various blueprints:

AirThreatLevel = 0, RegenRate = 0, SubThreatLevel = 0, EconomyThreatLevel = 0, SurfaceThreatLevel = 0

Testing done on the proposed changes

All units I tested still functioned normally.

Checklist

Basilisk3 commented 1 month ago

Specifically referring to:

* https://github.com/FAForever/spooky-db

* https://github.com/FAForever/UnitDB

Could you check and verify the code by searching for the blueprint field, and see if they properly allow the value to be missing?

A small example for the UnitDB is the fire rate that is missing on the Fire Beetle - it crashes the script.

I am not familiar with either repo, so correct me if I am wrong but here are my findings:

The UnitDB has this check: https://github.com/FAForever/UnitDB/blob/bbef3ca4c18145a04c43fc800b152813d8b74d12/www/res/scripts/functions.php#L1761C1-L1764C4

Spooky checks it too: https://github.com/FAForever/spooky-db/blob/e19cc5f560889f0c175f6f84465590082a038679/app/views/unit.html#L13