FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Fatboy unit detach bug + exFac footprint fix #6192

Closed clyfordv closed 1 month ago

clyfordv commented 1 month ago

Issues:

  1. Ordering "deploy" on the Fatboy will detach the unit under construction
  2. External factory dummy anchorUnits had a lingering footprint in the blueprint that blocked structure construction (minor, but aesthetically bad)

Fixes:

  1. Add a check in the fatboy script to make sure the detaching unit is complete--this could be generalized, but the fatboy is the only unit with this issue, and I believe it also has specific factory attach bone requirements
  2. Trim the anchor unit blueprint to remove footprint + additional unnecessary values

Afterthoughts:

  1. Anchor dummy unit still necessary to prevent selecting the exFac from the worldview
clyfordv commented 1 month ago

I was unaware of that, but I'm guessing it has to do with the build area needing to be free etc. etc. We could chase that goose but I think the return would be minimal, I was mostly worried about the little square popping up (which looked scuffed).