search

FAForever / fa

Lua code for FAF
221 stars 228 forks source link

The player's kick fails when there are several teams in the lobby. #6219

Closed GodFuper closed 3 weeks ago

GodFuper commented 1 month ago

https://github.com/FAForever/fa/blob/6625471d6762dd0b421a17233b709c5597ac8fb2/lua/ui/lobby/lobby.lua#L4368

Describe the bug The kick observer with index 0 fails.

To Reproduce Put multiple players in Observers. And try to kick it at the top one.

Expected behavior A window with "Are you sure?" should appear. So that you can kick.

Screenshots Анимация6

GodFuper commented 1 month ago

изображение If there are 2 teams in lobby, then you will not be able to kick the first 2 Observers. The whole function needs to be reviewed, as it does not work correctly. https://github.com/FAForever/fa/blob/6625471d6762dd0b421a17233b709c5597ac8fb2/lua/ui/lobby/lobby.lua#L4351-L4364

Garanas commented 1 month ago

Best bug report of the season 👍 , @4z0t or @lL1l1 would either of you have time to look into it?