FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Fix not being able to kick observers in team games #6222

Closed lL1l1 closed 3 weeks ago

lL1l1 commented 1 month ago

Description of the proposed changes

Fixes #6219. Also fixes being able to try to kick the team rating row when there are 3+ teams.

Testing done on the proposed changes

Open two instances of the game. Host multiplayer LAN on a specific port, and connect to localhost:thatport on the other instance (automatic port and discovery doesn't seem to work). Move the second player to observer, and add AIs to change the team sizes (set auto teams to None). Test being able to pop up the kick dialogue only when clicking the observer in all combinations of spawns fixed/not fixed and having 0-3 teams.

Checklist

Garanas commented 1 month ago

Thank you for taking the time and effort to pick this up 👍 , I'll try to review it this weekend.