FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Evaluate the hitboxes of several units #6227

Closed Basilisk3 closed 2 weeks ago

Basilisk3 commented 4 weeks ago

Description of the proposed changes

In this replay (#22630167) you can see several Cybran units being able to evade the beams of Seraphim Tech 2 PDs.

In #22662363 you can shortly see Ascendants being missed at 17:40 onwards.

Changes: SizeZ of the Hoplite: 0.9 --> 1.0 SizeZ of the Zthuee: 0.9 --> 1.0 SizeZ of the Mantis: 1.0 --> 1.05 SizeZ of the Sky Slammer: 0.8 --> 0.85 SizeZ of the Ascendant: 1.0 --> 1.1 SizeZ of the Asylum: 1.0 --> 1.05 SizeY of the Redeemer: 1.5 --> 1.1

Explanation of the changes: Hoplite and Zthuee: a SizeZ of 0.9 is low and can be increased without making the hitbox disproportionate to its mesh. Mantis and Sky Slammer: attempt to fix the issue while keeping their hitbox reasonable.

Testing done on the proposed changes

The bug is not reproducible offline, but does occur in games. For further context see #5768.

Checklist

Garanas commented 3 weeks ago

Would you have the time to add screenshots of the new collision sizes?

Garanas commented 1 week ago

The size changes to the Aeon tech 2 mobile shield also changes their footprint, see also:

image

This is probably unintended, are you available to make a PR to define the footprint in the blueprint?

Basilisk3 commented 1 week ago

Interesting, I will tackle this before the patch.