search

FAForever / fa

Lua code for FAF
226 stars 232 forks source link

Beams can miss units that already existed before the beam weapon was constructed #6250

Open Basilisk3 opened 3 months ago

Basilisk3 commented 3 months ago

Describe the bug As per the title. We have been trying to fix this by slightly increasing hitboxes of various units, and we have come a long way. Though it does seem like there is something else going on, that we currently do not understand.

To Reproduce

  1. Launch a sandbox game with cheats enabled.
  2. Enable the NoDamage console command.
  3. Spawn in a Wagner or a similar unit. Quick units with smaller hitboxes are affected the most.
  4. Spawn in 30 Seraphim Tech 2 PDs in a circle
  5. Have the PDs attack the unit and move it in circles.

The bug does not occur when you spawn the PDs first instead of the Wagner.

Expected behavior A clear and concise description of what you expected to happen.

Additional context For further context and replays, see https://github.com/FAForever/fa/issues/5768 and https://github.com/FAForever/fa/pull/6227.

Basilisk3 commented 3 months ago

A recent example of this can be observed in 22732109. At 15:20, a Seraphim destroyer can be seen missing Auroras, even though Auroras should have sufficient SizeZ at 1.1. The cause of this appears to be the fact that the Auroras were built before the destroyer was.