FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Fix overcharge not being fully absorbed by shields #6257

Closed lL1l1 closed 2 weeks ago

lL1l1 commented 2 weeks ago

Description of the proposed changes

There was an idea to not just set OC damage higher if it was below the structure/command damage, but it makes it weird since the 0.25 structure armor for OC starts taking effect which would require creating a new damage type for FAF overcharges which seems unnecessary.

Testing done on the proposed changes:

Shoot a titan (personal shield) and an ED1 (static shield) with the main fire (direct damage, so it doesn't trigger OnGetDamageAbsorption) or overcharge (AoE damage, OC special case) of a Seraphim SACU and check that the damage is correct (800 for OC) and there are no errors.

Checklist

lL1l1 commented 2 weeks ago

Gonna split the pr, it has issues with throwing away incorrect damage instances.