FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Make shields absorb full overcharge damage #6258

Closed lL1l1 closed 2 weeks ago

lL1l1 commented 2 weeks ago

Description of the proposed changes:

Sets shield absorption of overcharge damage type to 1.0 by default. So that units do not take damage from OC when standing at the edge of a shield.

Testing done on the proposed changes:

Shoot a UEF bubble shield or any static shield and they take 400/800 damage without letting through any damage to nearby units underneath.

Additional Context

Cherry picked from #6257, further details on the armor multiplier comment there.

Checklist

MrRowey commented 2 weeks ago

Wasn't it on purpose that oc did less dmg to stationary buildings ?

Garanas commented 2 weeks ago

That's not what this pull request is changing. What it is changing (I think) is eventually using the armor multiplier so that increased (or decreased) damage on one unit type does not necessarily affect another.

Or, what Nomander wrote right below 😃

lL1l1 commented 2 weeks ago

This doesn't change how much damage OC does to buildings, it fixes the bug where a unit standing at the edge of a shield will take 938 damage from the OC splash, even though it should be protected by the shield.

MrRowey commented 2 weeks ago

This doesn't change how much damage OC does to buildings, it fixes the bug where a unit standing at the edge of a shield will take 938 damage from the OC splash, even though it should be protected by the shield.

AHH gotcha, yh that's a nice fix 😎

MrRowey commented 2 weeks ago

@lL1l1 is this ready?

lL1l1 commented 2 weeks ago

Yes