FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Format the majority of the remaining blueprint files #6272

Closed Garanas closed 1 week ago

Garanas commented 1 week ago

Continuation of #6271

The only blueprint files that are not formatted are the emitter files. It would merge the key-based and value-based fields, creating a bit of a mess. Luckily we won't be doing much (if any) batch processing on those type of files.

With this we can now finally start batch processing file empowered by the Brewlan WikiGen made by @The-Balthazar. This would empower us to do various edits to units, props and projectiles an mass and bake them right into the blueprint files.

Basilisk3 commented 1 week ago

@Garanas What do we do with the campaign-related and miscellaneous units? E.g.: https://github.com/FAForever/fa/blob/develop/units/XAC0101/XAC0101_unit.bp

Garanas commented 1 week ago

We can include them if we want, but how the blueprints are now is also harmless. What would you prefer?

Basilisk3 commented 1 week ago

I never used them for anything. If the memory gains are negligible, then the only advantage I can think of is uniformity. There are a lot of these units, so maybe it is worth it. But only if the amount of time required is reasonable, of course👍