FAForever / fa

Lua code for FAF
221 stars 228 forks source link

Revert FiringState OnLostTarget working through HaltFire #6289

Closed lL1l1 closed 5 days ago

lL1l1 commented 1 week ago

Description of the proposed changes

Essentially reverts it to Steam behavior, except we have the fix for the state to call the base class.

Testing done on the proposed changes

Tested units with various firing cycles, particularly relevant are Ravager, Ythotha and its storm, GC Beam after tractoring something, and Scathis.

Spawn units command: ``` CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xsl0301_missile', 0, 3.82, 0.50, 0.00000) CreateUnitAtMouse('dslk004', 0, 11.82, -4.50, 0.00000) CreateUnitAtMouse('delk002', 0, 8.82, -4.50, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xsb2301', 0, -4.24, 1.83, 2.64765) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xsb2401', 0, -8.24, -8.17, 0.00000) CreateUnitAtMouse('drl0204', 0, 10.15, -0.33, 0.02394) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('urb2108', 0, 9.76, 5.83, 0.00000) CreateUnitAtMouse('uel0001', 0, 2.17, 5.30, 0.51364) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('url0401', 0, -11.74, 7.08, -0.00668) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xsb2108', 0, 12.76, 6.83, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xel0306', 0, -2.10, 5.51, -0.57607) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xeb2306', 0, -8.24, 7.83, 2.60117) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xsl0401', 0, 14.76, 0.83, -0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xab1401', 0, -1.24, -8.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('url0304', 0, -5.25, 5.22, 0.23978) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('del0204', 0, 6.23, 5.95, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('drlk001', 0, 5.82, -4.50, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('xrb0304', 0, -0.24, -0.17, 0.00000) CreateUnitAtMouse('ual0401', 0, -18.30, -3.43, 0.21756) ```

Checklist